-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cache from test CI #3422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
added
bug
Something isn't working as expected
github actions
Pull requests that update GitHub Actions code
and removed
bug
Something isn't working as expected
labels
Jan 25, 2023
curquiza
changed the title
Remove cache from Windows and macOs CIs
Remove cache from test CI
Jan 25, 2023
dureuill
reviewed
Jan 25, 2023
Co-authored-by: Louis Dureuil <louis@meilisearch.com>
dureuill
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
bors merge |
bors bot
added a commit
that referenced
this pull request
Mar 13, 2023
3587: Enable cache again in test suite CI r=curquiza a=curquiza Following the change in this PR introduced in v1.1: #3422 The cache was removed due to failures (lack of space). Now the binary is smaller (from 250Mb to 50Mb) we want to try to enable the cache again. Indeed, without the cache step, the CIs are wayyyy slower (45min instead of 20-30min). For later: Rust 1.68 introduced a new way to fetch crates. Updating the rust version might also help in the future! Co-authored-by: curquiza <clementine@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
github actions
Pull requests that update GitHub Actions code
maintenance
Issue about maintenance (CI, tests, refacto...)
v1.1.0
PRs/issues solved in v1.1.0 released on 2023-04-03
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment the lines in CIs where we use the test CIs
We indeed have cache issues (lack of space on the machine) when running our test CIs
#3403